-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure changed labels are kept after a clone (fix ROOT-10580) #5041
Conversation
Starting build on |
Build failed on ROOT-fedora27/noimt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it is a good idea to reimplement TF1::Clone using TF1::Copy. In principle Clone should rely on the ROOT I/O and TF1 knows about this and for example in case of TF1 based on compile functor, which cannot be cloned, it uses a special treatment.
Maybe there is another way to fix the bug observed when calling DrawClonePad.
Also why adding a new public function SetHistogram(), is this really something we want ?
Build failed on ROOT-fedora30/cxx14. Failing tests: |
Build failed on mac1014/cxx17. Failing tests: |
Build failed on ROOT-ubuntu18.04-i386/cxx14. Failing tests: |
Build failed on ROOT-performance-centos7-multicore/default. |
Starting build on |
@lmoneta I have push the new version. May be you can look at it. Thanks |
Starting build on |
remove spaces
Starting build on |
TObject* TF1::Clone(const char*) const | ||
{ | ||
|
||
TF1* obj = (TF1*) TNamed::Clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you pass the new name/argument to TNamed::Clone()
…t-project#5041) * Make sure changed labels are kept after a clone (fix ROOT-10580) * new version using TObject::Clone... * Fix to avoid double delete of fHistogram * Use TNamed::Clone remove spaces
No description provided.